feat(ads): wrap the Google Ads surface - #23
Merged
Merged
Conversation
client.ads.google covers what only Google has: keywords and keyword ideas, search terms, bid strategies, ad schedule, negative keyword lists, assets, Performance Max asset groups, Local Services leads, conversions, and query for a raw GAQL read. Campaigns, ad groups, ads, audiences and insights stay on client.ads, where they dispatch by connection. client.ads.authorize_google starts the connection.
# Conflicts: # src/fopost/models.py # src/fopost/resources/ads.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.ads.googlecovers what only Google has: keywords and keyword ideas, search terms, bid strategies, ad schedule, negative keyword lists, assets, Performance Max asset groups, Local Services leads, conversions, andqueryfor a raw read-only GAQL SELECT.Campaigns, ad groups, ads, audiences and insights stay on
client.ads, where they dispatch by connection.client.ads.authorize_googlestarts the connection.Every call names a
customer_idthe connection's grant reaches; any other answers 404. Amounts stay in the account's currency, minor units.Merged with main (29 commits: contacts, broadcasts, sequences, catalogs). Both conflicts were additive — the new models sit beside main's, and the
adsmodule docstring now names both networks.Needs fopost/fopost#997 on the API side. 134 tests pass; ruff, mypy and the format check are clean.